search

daostack / infra

GNU General Public License v3.0
25 stars 22 forks source link

GP doesn't fire StateChange event when proposal moves to QuietEndingPeriod #61

Closed ben-kaufman closed 5 years ago

ben-kaufman commented 5 years ago

When changing the state of a proposal to QuietEndingPeriod Genesis protocol currently doesn't emit a StateChange event as it would be expected to do and currently does for all other state changes.

Genesis protocol should emit a StateChange event here: https://github.com/daostack/infra/blob/master/contracts/votingMachines/GenesisProtocolLogic.sol#L706

orenyodfat commented 5 years ago

This is nice to have though it is not a must .

Subgraph already read the proposal upon voting event and should also update its state

On Sun, 21 Apr 2019 at 17:34 benk10 notifications@github.com wrote:

When changing the state of a proposal to QuietEndingPeriod Genesis protocol currently doesn't emit a StateChange event as it would be expected to do and currently does for all other state changes.

Genesis protocol should emit a StateChange event here:

https://github.com/daostack/infra/blob/master/contracts/votingMachines/GenesisProtocolLogic.sol#L706

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/daostack/infra/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNXPHUOKTD23ESCIRB2Y2LPRSCQDANCNFSM4HHL33LA .