#3 Facilitate executing new Alchemy installation against ganache

[dkent600]

Implements #3, Facilitate executing new Alchemy installation against ganache.

Pairs with the recent arc-js PR

[dkent600]

@orenyodfat

Please add travis tests.

Adding tests is part of another PR: https://github.com/daostack/Alchemy-Aurelia/issues/10. If I add travis test support now it would be as an empty .travis.yml file. Is that what you want?

Please remove commented code.

My understanding is that your concern here is about "messy" code in NPM packages. This repo is not being published as an npm package (what would be the point?). While there is certainly some commented-code that could easily be removed, there are other bits that are important in the flow of ongoing work and I would really prefer not to remove them. Is that OK with you?

[orenyodfat]

@dkent600

Adding tests is part of another PR: #10. If I add travis test support now it would be as an empty .travis.yml file. Is that what you want?

It is very handful and useful to add an automated tests which try to cover code you submit. For the one who submit the pr and the one who reviewing it. It would also catch simple issues like failing at "npm install"

My understanding is that your concern here is about "messy" code in NPM packages. This repo is not being published as an npm package (what would be the point?). While there is certainly some commented-code that could easily be removed, there are other bits that are important in the flow of ongoing work and I would really prefer not to remove them. Is that OK with you?

This repo is being publish as part of DAOstack github.It does not matter if it produced NPM package or not. If you must have commented code so keep it in a branch on a forked repo . I would suggest to remove any commented code which can be removed.

[dkent600]

@orenyodfat Regarding adding travis tests: I have introduced a .travis.yml file, but travis won't start using it until it appears in the master branch, ie, until this PR is merged.

[dkent600]

@orenyodfat I just committed changes that removed a lot of commented-out code and froze all the address links when running against ganache. I previously introduced a .travis.yml file. So I believe I've addressed all your concerns (unless you know of some way to implement your request to make the links work against the ganache GUI application).

[dkent600]

Regarding adding travis tests: I have introduced a .travis.yml file, but travis won't start using it until it appears in the master branch, ie, until this PR is merged.

Actually I was wrong, it has begun running the test.

[orenyodfat]

@dkent600 please help travis to become green .

[dkent600]

Approve and merge the outstanding end-to-end PR so we can submit a PR that fixes the GlobalConstraints dashboard.

[leviadam]

Hi @dkent600, do we need to commit this file .vscode/launch.json? Isn't it a workspace file?

[leviadam]

@dkent600 this branch is now not working for me. Namely, I get errors when trying to start the demo. Please check.

[dkent600]

@leviadam

this branch is now not working for me.

Can you please give more specifics? What do you mean "when trying to start the demo" and what are the error messages, where are you seeing them?

The fact that the Truffle tests are working should mean that the scripts are not failing.

Dunno what the error is, but you might try deleting the node_modules folder and package-lock.json and do an npm install.

Thanks

[leviadam]

I removed the repo completely. Cloned it again. Did npm install. Then npm start, I get:

npm start  

> daostack-alchemy@0.0.0-alpha.3 start /home/adam/cryptoDev/Ethereum/daostack/Alchemy-Aurelia
> nps

nps is executing `default` : nps arc-js.ganache.runAsync && nps arc-js.migrateContracts && nps build.development && nps browse
nps is executing `arc-js.ganache.runAsync` : npm explore daostack-arc-js -- npm start test.ganache.runAsync

> daostack-arc-js@0.0.0-alpha.14 start /home/adam/cryptoDev/Ethereum/daostack/Alchemy-Aurelia/node_modules/daostack-arc-js
> nps "test.ganache.runAsync"

nps is executing `test.ganache.runAsync` : osascript -e 'tell application "Terminal"' -e 'tell application "System Events" to keystroke "t" using {command down}' -e 'do script "cd /home/adam/cryptoDev/Ethereum/daostack/Alchemy-Aurelia/node_modules/daostack-arc-js && npm start test.ganache.run" in front window' -e 'end tell'
/bin/sh: 1: osascript: not found
The script called "test.ganache.runAsync" which runs "osascript -e 'tell application "Terminal"' -e 'tell application "System Events" to keystroke "t" using {command down}' -e 'do script "cd /home/adam/cryptoDev/Ethereum/daostack/Alchemy-Aurelia/node_modules/daostack-arc-js && npm start test.ganache.run" in front window' -e 'end tell'" failed with exit code 127 https://github.com/kentcdodds/nps/blob/v5.7.1/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! daostack-arc-js@0.0.0-alpha.14 start: `nps "test.ganache.runAsync"`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the daostack-arc-js@0.0.0-alpha.14 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/adam/.npm/_logs/2018-01-24T14_10_03_400Z-debug.log
npm ERR! weird error 1
The script called "arc-js.ganache.runAsync" which runs "npm explore daostack-arc-js -- npm start test.ganache.runAsync" failed with exit code 1 https://github.com/kentcdodds/nps/blob/v5.7.1/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
The script called "default" which runs "nps arc-js.ganache.runAsync && nps arc-js.migrateContracts && nps build.development && nps browse" failed with exit code 1 https://github.com/kentcdodds/nps/blob/v5.7.1/other/ERRORS_AND_WARNINGS.md#failed-with-exit-code
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! daostack-alchemy@0.0.0-alpha.3 start: `nps`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the daostack-alchemy@0.0.0-alpha.3 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/adam/.npm/_logs/2018-01-24T14_10_03_432Z-debug.log

[dkent600]

@leviadam Per the Readme:

If npm start doesn't work for you, and for more information about the scripts involved, see the following section "Build and Run".

Under there you will find:

Fire up ganache (testrpc) in a separate window

npm start arc-js.ganache.runAsync

Note: If the window didn't fire up in your OS, then run this in a separate window of your own creation:

npm start arc-js.ganache.run

Try that and let me know...

[dkent600]

@leviadam

do we need to commit this file .vscode/launch.json?

I have removed this folder.

[leviadam]

@dkent600 I checked also the other script, not just npm start, they also do not work.

[dkent600]

@leviadam

Are you saying that npm start arc-js.ganache.run did not work for you?

Need more details as before...thanks

[dkent600]

@leviadam I removed the word "Emergent"

[dkent600]

@leviadam With regard to your problems running the scripts on linux:

I ran them in a Bash shell. This is not a full installation of Ubuntu, but is likely close enough.

I did encounter some issues relating to npm packages and one issue of a case-sensitive filename mismatch. Not knowing exactly what your issues were, I can't know that these are the same issues you encountered.

In any case, I made changes and added a couple trouble-shooting instructions in the readme.

Can you please try again? If you encounter problems, please check the readme for new suggestions that might help.

Thanks

[leviadam]

Still not working.

[dkent600]

Created #24 to make the arc-js.ganache.runAsync work with Linux. Made the readme more directly target Linux users in this.

[dkent600]

For some reason this PR isn't showing it in the GUI, but the tests are succeeding:

https://travis-ci.org/daostack/Vanilla

[dkent600]

@orenyodfat If you have any further comments about documentation that don't pertain to running scripts, can you please just add them to this issue: #27, not to this PR?

Thanks!