Closed aristotelis96 closed 1 year ago
@pdamme @corepointer I would kindly ask for a confirmation from your side that this is the correct way to parse the dialect before merging this.
By the way, this PR is related to #154 and #155.
Thank you @pdamme for your feedback. I've slightly extended the parser test in order to check IR-parsing after MatrixRepresentationPass
, since these changes affect IR produced by that pass.
While parsing a matrix object the "sparsity" and "rerpesentation" arguments can both exist. In that case trying to parse one of them while multiple exist, can make the parser emmit errors. We should consider them optional while trying to parse them in the loop.
This is currently an issue for the distributed runtime, since distributed workers emmit errors while parsing the IR sent by the coordinator.
Example IR that a matrix contains both "sparsity" and "representation" and parsing it emits errors: