[DAPHNE-#702] Config parameter for sparsity threshold

corepointer commented 7 months ago

This commit adds a configuration item to DaphneUserConfig to let the user specify a sparsity threshold. This is arbitrarily set to 25% by default (from the non-configurable previous default of 10%). Furthermore, all the required changes to read the threshold (from json) to passing it down to the SelectMatrixRepresentationsPass are implemented. Two more misc comments:

Added the config param explain_select_matrix_repr to the default UserConfig.json
Removed createSelectMatrixRepresentationPass from Passes.td as passing arguments is not supported by TableGen (as I found out here [1])

1

Closes #702

corepointer commented 5 months ago

Thx for the review @pdamme!

I squashed your cleanups into the main commit
For commits that go into main via a PR and do not have a separate GH issue number I use the PR number to reference the discussion. This should be fine because issue and PR number share the same sequence.
I did not add the "daphne-eu". In the plain text commit message it's just "DAPHNE- # 702" (spaces added so it is not rendered to fancy format here). Maybe it's just a GH display issue?

pdamme commented 5 months ago

Thanks for squashing and merging.
Sounds like a good idea.
Okay, sorry, my mistake ;) .

daphne-eu / daphne

[DAPHNE-#702] Config parameter for sparsity threshold #702