This PR aims to update the software requirements needed to compile DAPHNE without containers.
The list of required packages has been sorted alphabetically and extended with zlib1g-dev to satisfy a cmake dependency and unzip.
Furthermore, the existing install-ubuntu-packages.sh script has been updated to install cmake using snap on Ubuntu 20.04 to fulfill the version requirement, as well as a newer version of llvm-*-tools on current releases. However, there are two points to consider:
For Ubuntu 18.04 it references the documentation ("custom toolchain needed") but I am not aware of any further clarification in the documentation to help setup the environment, which makes it difficult to proceed with the setup.
If the Ubuntu version is not 18.04, 20.04, 22.04, or 24.04, the script asks whether to continue or not and assumes llvm-15-tools is available with apt which is generally not guaranteed. Should the prompt be deleted perhaps or is this assumption acceptable?
I have tested the script as well as successful compilation and tests using Ubuntu 20.04, 22.04 and 24.04 using WSL2 on Windows 11.
There is an issue regarding a failing test with decision trees possibly relating to this (#787). I am not sure if this indicates more missing dependencies in the script that are present in the current docker container.
I found that e.g. g++ 13.2 compiles correctly but triggers a lot of overloaded-virtual warnings for virtual void rewrite (mlir::RewritePattern in lowering passes) and virtual bool antlr4::tree::ParseTree::operator==. Perhaps this should be addressed in a new issue.
This PR aims to update the software requirements needed to compile DAPHNE without containers. The list of required packages has been sorted alphabetically and extended with
zlib1g-devto satisfy acmakedependency andunzip. Furthermore, the existing install-ubuntu-packages.sh script has been updated to installcmakeusingsnaponUbuntu 20.04to fulfill the version requirement, as well as a newer version ofllvm-*-toolson current releases. However, there are two points to consider:Ubuntu 18.04it references the documentation ("custom toolchain needed") but I am not aware of any further clarification in the documentation to help setup the environment, which makes it difficult to proceed with the setup.18.04,20.04,22.04, or24.04, the script asks whether to continue or not and assumesllvm-15-toolsis available withaptwhich is generally not guaranteed. Should the prompt be deleted perhaps or is this assumption acceptable?I have tested the script as well as successful compilation and tests using
Ubuntu 20.04,22.04and24.04using WSL2 on Windows 11.There is an issue regarding a failing test with decision trees possibly relating to this (#787). I am not sure if this indicates more missing dependencies in the script that are present in the current docker container.
I found that e.g.
g++ 13.2compiles correctly but triggers a lot ofoverloaded-virtualwarnings forvirtual void rewrite(mlir::RewritePatternin lowering passes) andvirtual bool antlr4::tree::ParseTree::operator==. Perhaps this should be addressed in a new issue.