search

daphne-eu / daphne

DAPHNE: An Open and Extensible System Infrastructure for Integrated Data Analysis Pipelines
Apache License 2.0
67 stars 62 forks source link

[kernels] fix usage of C stdlib abs (#863) #864

Closed philipportner closed 1 month ago

philipportner commented 1 month ago

The EwUnary kernel used the C stdlib abs function which instead of the appropriate C++ std::abs function. This caused a bug where calling abs with floating point values were cast to integer values during conversion.

Closes #863

auge commented 1 month ago

would it make sense to also add a test case when we spot a bug like this?

philipportner commented 1 month ago

would it make sense to also add a test case when we spot a bug like this?

yes ofc! I already have them locally but forgot to push them with the PR and just want to let the CI run finish before I push again :)

m-birke commented 1 month ago

I tested it, works fine