search

daphne-eu / daphne

DAPHNE: An Open and Extensible System Infrastructure for Integrated Data Analysis Pipelines
Apache License 2.0
67 stars 62 forks source link

[DAPHNE-#867] Change ConfigParser::fileExists() behavior to not throw #867

Closed corepointer closed 1 month ago

corepointer commented 1 month ago

I consider this a bugfix but I'll run it through a PR to raise attention to the change. Tests are running fine (after fixing the one that tests the previous behavior). If there were no concerns raised by the time CI ran through I'll merge it right in.

Changing the behavior of fileExists() to a boolean operation as suggested by the method's name. Throwing an exception us up to the caller of this method.

Closes #867

corepointer commented 1 month ago

The same semantic problem exists with keyExists() imho. Bit I'll leave that one for future work as my main concern to change this in the first place was a failing distributed test that did not find its config file.

corepointer commented 1 month ago

Not sure if you wanted to close a related issue but you put the PR# itself in the description :)

Since issues and pull requests share the same sequence number, I frequently abuse this to have a ticket number and a place for discussion right here in the PR.