daphne-eu / daphne

DAPHNE: An Open and Extensible System Infrastructure for Integrated Data Analysis Pipelines
Apache License 2.0
67 stars 62 forks source link

VectorizedPipelineOp deduplication bug (#697) #872

Closed philipportner closed 1 month ago

philipportner commented 1 month ago

See #697.

To find duplicates, the canonicalize method of the VectorizedPipelineOp uses a std::vector to store the VectorSplits of its inputs. In the actual loop, the canonicalize method didn't use this std::vector, but was still fetching the splits from the VectorizedPipelineOp itself. This patch fixes this mistake. Now inputs that are used multiple times and have multiple splits are correctly considered for each usage.

Closes #697