search

daplf / vscode-java-kotlin

Experimental support for importing Kotlin code into Java projects via a JDT.LS extension
MIT License
25 stars 6 forks source link

Setup delegateCommandHandler to set KLS classpath entry #2

Closed daplf closed 2 years ago

daplf commented 2 years ago

Fixes https://github.com/fwcd/vscode-java-kotlin/issues/1

This changes the approach taken for interoperability. I removed the project importers and instead we now have a delegateCommandHandler that updates the classpath.

The whole thing works like this:

This PR also introduces the changes need to make this work with the vscode extensions (see also: https://github.com/fwcd/vscode-kotlin/pull/89)

PS: In order to test this, you need the changes from the 3 PRs. For the VSCode side, I'm not sure if you can debug two extensions at once, but you can always package one of them and install it from a vsix (and debug the other one).

daplf commented 2 years ago

@fwcd Thanks for reviewing and merging the client and server PRs. The only thing left now for Java + Kotlin interoperability is this PR. Do you mind taking a look at it? I have rights to merge this as is, but I would prefer if you looked at it as well. Once it's merged, we can publish vscode-java-kotlin so people can start trying it out.

fwcd commented 2 years ago

I am not very familiar with the JDT.LS APIs yet so I'd have to take some more time to look at this (and the entire extension) in detail, but from a quick glance it definitely looks good to me!

fwcd commented 2 years ago

So definitely feel free to merge (I hope to find some more time to review the project in detail, can't promise when though, sorry).

daplf commented 2 years ago

Alright, merging it then. Let me know when you've had a chance to look at it, so we can publish it

daplf commented 1 year ago

Hey @fwcd

It's been over a year since I built this companion extension. Perhaps I should just release this myself (if that's okay with you)? There's still many people requesting this every now and then (and having it in the vscode marketplace would be so much easier for them than having to build this themselves)

fwcd commented 1 year ago

Hi, sorry for the inactivity on this repo, unfortunately I don't really have the time to actively maintain this project.

Perhaps I should just release this myself

Sure, feel free to do so! Given that you wrote the extension pretty much yourself, we could also transfer the repo to your account if you'd like. (I'm fine either way, we can leave it here too)

daplf commented 1 year ago

Hi, sorry for the inactivity on this repo, unfortunately I don't really have the time to actively maintain this project.

No worries!

Sure, feel free to do so! Given that you wrote the extension pretty much yourself, we could also transfer the repo to your account if you'd like. (I'm fine either way, we can leave it here too)

I wrote it myself but it was based on some of your ideas 😄 But I think it makes sense to transfer it to my account, since I'll be the one maintaining it. Can you set that up?

fwcd commented 1 year ago

I've sent out a transfer request

daplf commented 1 year ago

Transferred. Thanks!