dapogon
commented
1 week ago Hi Jerry, thank you for letting me know. I will try to find some time soon to fix this. Best, D
David Posada CINBIO Universidade de Vigo 36310 Vigo Spain
Phone: +34 986 812038 Cell: +34 647 343300 Email: @.*** Web: http://darwin.uvigo.es
From: jarrybarber @.> Sent: Thursday, September 5, 2024 8:50 PM To: dapogon/cellcoal @.> Cc: Subscribed @.***> Subject: [dapogon/cellcoal] Site-specific ADOs aren't actually site-specific (Issue #6)
In the AllelicDropout function, alleleADOrateSite is resampled for each (cell,site) iteration rather than being sampled once and stored for reuse across all cell genotypes. This results in the ADO rates being about the same across all sites.
If helpful, I have attached a file with a fixed version of the function. fix.ziphttps://urldefense.com/v3/__https://github.com/user-attachments/files/16898955/fix.zip__;!!D9dNQwwGXtA!THNx4jumo8_pAGomVUv0ibneLlrUgXIyLbwlL0I415SAxYLFjy4lecLeEa2Q1oyFMYLbGJWOwo5oF_MbDbz3H0HE$
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/dapogon/cellcoal/issues/6__;!!D9dNQwwGXtA!THNx4jumo8_pAGomVUv0ibneLlrUgXIyLbwlL0I415SAxYLFjy4lecLeEa2Q1oyFMYLbGJWOwo5oF_MbDd0yIwse$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AE4VEEUS7SDGPFFMYVZMO7LZVCRXRAVCNFSM6AAAAABNXDDL3KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYDQNJQGA3DQNQ__;!!D9dNQwwGXtA!THNx4jumo8_pAGomVUv0ibneLlrUgXIyLbwlL0I415SAxYLFjy4lecLeEa2Q1oyFMYLbGJWOwo5oF_MbDYXwS0CW$. You are receiving this because you are subscribed to this thread.Message ID: @.***>
In the AllelicDropout function, alleleADOrateSite is resampled for each (cell,site) iteration rather than being sampled once and stored for reuse across all cell genotypes. This results in the ADO rates being about the same across all sites.
If helpful, I have attached a file with a fixed version of the function. fix.zip