search

dapper91 / pjrpc

python json-rpc client/server without boilerplate
https://pjrpc.readthedocs.io
The Unlicense
32 stars 3 forks source link

Update aio-pika backend to aio-pika 8.0 #68

Closed bernhardkaindl closed 2 years ago

bernhardkaindl commented 2 years ago

aio-pika 7.0 and 8.0 have a number of improvements over aio-pika 6.8 which pjrpc currenty uses.

The changes to switch to 8.0 (or 7.0) are rather small:

Only the special case when a specific result_queue_name with result_queue_args needs an actual change, the remaining changes are only fixes for mypy type annotations for the type changes since aio-pika 7.0

Also add am example demonstrating the use of such specific result queue.

codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (41c442f) into dev (68d17db) will decrease coverage by 0.12%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev      #68      +/-   ##
==========================================
- Coverage   78.71%   78.59%   -0.13%     
==========================================
  Files          40       40              
  Lines        2584     2588       +4     
==========================================
  Hits         2034     2034              
- Misses        550      554       +4
Flag Coverage Δ
unittests 78.59% <0.00%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pjrpc/client/backend/aio_pika.py 0.00% <0.00%> (ø)
pjrpc/server/integration/aio_pika.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68d17db...41c442f. Read the comment docs.

bernhardkaindl commented 2 years ago

@dapper91 please consider this update of aio-pika to 7.0/8.0, details in the description.

The coverage can only be increased by adding a rabbitmq container to the github action because to reach the update code, a connect() to RabbitMQ needs to succeed.

I'll look into that for a later PR.