search

dapper91 / pjrpc

python json-rpc client/server without boilerplate
https://pjrpc.readthedocs.io
The Unlicense
32 stars 3 forks source link

kombu client hanging bug fixed #76

Closed dapper91 closed 2 years ago

dapper91 commented 2 years ago

Reason: kombu client creates a response queue implicitly after a request has been sent to the server. If the server finishes handling the request before the response queue is created then the response message will be lost. In such case the client hangs forever waiting for the response from the server.

Solution: This fix forces the client to create the response queue explicitly just before the request is sent which prevents the response message from being lost.

Issue: https://github.com/dapper91/pjrpc/issues/66

codecov-commenter commented 2 years ago

Codecov Report

Merging #76 (08cbe2a) into dev (8d86b55) will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev      #76      +/-   ##
==========================================
- Coverage   78.74%   78.71%   -0.04%     
==========================================
  Files          40       40              
  Lines        2583     2584       +1     
==========================================
  Hits         2034     2034              
- Misses        549      550       +1
Flag Coverage Δ
unittests 78.71% <0.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pjrpc/client/backend/kombu.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d86b55...08cbe2a. Read the comment docs.