dapper91 / pjrpc

python json-rpc client/server without boilerplate
https://pjrpc.readthedocs.io
The Unlicense
32 stars 3 forks source link

make init test: install extra-depends for test #78

Closed bernhardkaindl closed 2 years ago

bernhardkaindl commented 2 years ago

@dapper91 Hi Dimitry,

Currently, .github/workflows/test.yml runs poetry install with

                                 -E aiohttp -E flask -E httpx -E jsonschema -E pydantic -E requests \
                                 -E docstring-parser -E werkzeug -E openapi-ui-bundles

But make init test also needs these modules. Therefore add them to [tool.poetry.dev-dependencies] instead.

For the Makefile: After pyproject.toml was updated, poetry.lock must be re-generated. Use poetry update to ensure that.

Also add minor warning fix: Silence deprecation warnings from make test by adding export PYTHONWARNINGS=ignore::DeprecationWarning to Makefile.

codecov-commenter commented 2 years ago

Codecov Report

Merging #78 (1ff8a0c) into dev (68d17db) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #78   +/-   ##
=======================================
  Coverage   78.71%   78.71%           
=======================================
  Files          40       40           
  Lines        2584     2584           
=======================================
  Hits         2034     2034           
  Misses        550      550           
Flag Coverage Δ
unittests 78.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68d17db...1ff8a0c. Read the comment docs.

bernhardkaindl commented 2 years ago

@dapper91 please look @ merging pyproject.toml, the update of the Makefile is minor, but tested to work

bernhardkaindl commented 2 years ago

@dapper91 another ping

bernhardkaindl commented 2 years ago

Fixed already in #86