Closed bernhardkaindl closed 1 year ago
Merging #90 (5b168b4) into dev (064c5c6) will increase coverage by
0.05%
. The diff coverage is97.63%
.
@@ Coverage Diff @@
## dev #90 +/- ##
==========================================
+ Coverage 79.49% 79.55% +0.05%
==========================================
Files 41 41
Lines 2717 2719 +2
==========================================
+ Hits 2160 2163 +3
+ Misses 557 556 -1
Flag | Coverage Δ | |
---|---|---|
unittests | 79.55% <97.63%> (+0.05%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pjrpc/client/backend/aio_pika.py | 0.00% <0.00%> (ø) |
|
pjrpc/client/backend/kombu.py | 0.00% <0.00%> (ø) |
|
pjrpc/__about__.py | 100.00% <100.00%> (ø) |
|
pjrpc/client/client.py | 97.55% <100.00%> (ø) |
|
pjrpc/client/integrations/pytest.py | 91.85% <100.00%> (ø) |
|
pjrpc/common/__init__.py | 91.66% <100.00%> (ø) |
|
pjrpc/common/common.py | 89.28% <100.00%> (+0.82%) |
:arrow_up: |
pjrpc/common/exceptions.py | 98.64% <100.00%> (ø) |
|
pjrpc/common/v20.py | 91.22% <100.00%> (ø) |
|
pjrpc/server/dispatcher.py | 87.73% <100.00%> (+0.04%) |
:arrow_up: |
... and 5 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hello!
This is a minor improvement to fix
mypy
of a currently not used RPC endpoint function inexamples/aio_pika_server.py
:Details:
The
add_user()
example inexamples/aio_pika_server.py
is not yet used by the example client, so it can be fixed formypy
usingdataclasses
similar to the exampleadd_user()
with dataclasses at the end of README.rst: https://github.com/dapper91/pjrpc/blob/master/README.rst#open-api-specification@dapper91: The 1st commit of this branch is the commit from #89 as it's context depends on it. It can be merged after (or instead of) #89.
It reduces the coverage percentage very slightly because the updated lines in the unused function is not yet covered. If this is approved or merged, a test case covering using RabbitMQ in the github actions: