search

dapper91 / pydantic-xml

python xml for humans
https://pydantic-xml.readthedocs.io
The Unlicense
141 stars 14 forks source link

documentation comment update #123

Closed potyl closed 9 months ago

potyl commented 9 months ago

The comment for products wasn't referencing the proper extraction source. We're now highlighting that the product entries are coming from <Company> children.

dapper91 commented 9 months ago

@potyl thanks for your contribution.

Please, change the target branch from master to dev.

potyl commented 9 months ago

@dapper91 I have rebased my branch on top of dev.

codecov-commenter commented 9 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (33cf243) 91.61% compared to head (ed384ca) 91.61%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #123 +/- ## ======================================= Coverage 91.61% 91.61% ======================================= Files 25 25 Lines 1359 1359 ======================================= Hits 1245 1245 Misses 114 114 ``` | [Flag](https://app.codecov.io/gh/dapper91/pydantic-xml/pull/123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dmitry+Pershin) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dapper91/pydantic-xml/pull/123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dmitry+Pershin) | `91.61% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Dmitry+Pershin#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.