dapper91
commented
1 year ago @lmmx Hi.
Your xml document defines the default namespace, so all sub-elements (including loc and lastmod) belongs to that namespace. When you defined a sub-model nsmap parameter is not inherited from the parent one.
So your model
class Url(BaseXmlModel, nsmap={}):
loc: Loc
lastmod: LastModdoesn't inherit default namespace from UrlSet which means it tries to find loc and lastmod without namespace.
Try to redefine Url model like this:
class Url(BaseXmlModel, nsmap=NSMAP):
loc: Loc
lastmod: LastMod
lmmx
I tried to parse a XML document with a schema URL and got a failure, which I think only occurs when there's a namespace set on the XML model.
I read the tests and followed the exact layout used there for nested submodels in case it was my mistake (since this is my first time using this library), but it seems to only occur when a namespace schema URL is in the top model.
It doesn't seem to be due to this namespace map being inherited, because setting an empty
nsmapon the first submodel (to 'undo' the inherited namespace) doesn't change the error either.The following test case demonstrates the bug, adapted from this test
Result
(Abbreviated for clarity)
Click to show entire pytest output
Result: ```sh (magicscrape) louis 🚶 ~/dev/testing/pydantic_xml $ pytest submodels_ns.py ``` ```py [615/1944] ========================================================================== test session starts ========================================================================== platform linux -- Python 3.10.12, pytest-7.4.0, pluggy-1.2.0 rootdir: /home/louis/dev/testing/pydantic_xml plugins: anyio-3.7.1 collected 2 items submodels_ns.py .F [100%] =============================================================================== FAILURES ================================================================================ ____________________________________ test_nested_root_submodel_element_extraction[True-http://www.sitemaps.org/schemas/sitemap/0.9] _____________________________________ use_ns = True, schema_url = 'http://www.sitemaps.org/schemas/sitemap/0.9' @mark.parametrize("schema_url", ["http://www.sitemaps.org/schemas/sitemap/0.9"]) @mark.parametrize("use_ns", [False, True]) def test_nested_root_submodel_element_extraction(use_ns, schema_url): if use_ns: NSMAP = {"": schema_url} else: NSMAP = {} class Loc(RootXmlModel, tag="loc"): root: int class LastMod(RootXmlModel, tag="lastmod"): root: int class Url(BaseXmlModel, nsmap={}): loc: Loc lastmod: LastMod class UrlSet( BaseXmlModel, tag="urlset", nsmap=NSMAP, ): url: list[Url] = element() ns = f' xmlns="{schema_url}"' if use_ns else "" xml = f"""I also verified that it isn't a regression due to the move to Pydantic 2, the same result occurs with v1 syntax:
Click to show Pydantic v1 version
```py from pytest import mark from pydantic_xml import BaseXmlModel, element @mark.parametrize("schema_url", ["http://www.sitemaps.org/schemas/sitemap/0.9"]) @mark.parametrize("use_ns", [False, True]) def test_nested_root_submodel_element_extraction(use_ns, schema_url): if use_ns: NSMAP = {"": schema_url} else: NSMAP = {} class Loc(BaseXmlModel, tag="loc"): __root__: int class LastMod(BaseXmlModel, tag="lastmod"): __root__: int class Url(BaseXmlModel, nsmap={}): loc: Loc lastmod: LastMod class UrlSet( BaseXmlModel, tag="urlset", nsmap=NSMAP, ): url: list[Url] = element() ns = f' xmlns="{schema_url}"' if use_ns else "" xml = f"""From the traceback I breakpointed the
model.pyandserializers/factories/model.pymodules and inspected withbreakpoint()andtraceback.print_stack()which showed that the validation error is occurring because theUrlvalidator (i.e. the submodel) is first being passed a correctsourceof the<url>...</url>substring, which becomes a validresultdict and passes themodel_validatecall, but then on a 2nd pass receives an incorrectsourceequal to the entire XML string, which produces an emptyresultdict which fails the 2ndmodel_validatecall.I.e. the
ValidationErroris arising from trying to interpret the entire XML string as the submodel, which is obviously going to fail.I don't know if this internal view really helps debug it or not but it might point to the root cause, and rule out a failure to parse the submodel, but a failure to parse only that submodel.
Click to show the real XML that was simplified for this example
Initial demo script: ```py from typing import Optional from pydantic import ValidationError from pydantic_xml import BaseXmlModel, RootXmlModel, attr, element class Loc(RootXmlModel, tag="loc"): root: str class LastMod(RootXmlModel, tag="lastmod"): root: str class Url(BaseXmlModel): loc: Loc lastmod: LastMod class UrlSet( BaseXmlModel, tag="urlset", nsmap={"": "http://www.sitemaps.org/schemas/sitemap/0.9"}, ): url: list[Url] = element() urlfree = b'