search

dapperlabs / nba-smart-contracts

Smart contracts and transactions for Topshot, the official NBA digital collectibles game on the Flow Blockchain
https://www.nbatopshot.com
The Unlicense
333 stars 105 forks source link

Use correct interface types in linking #210

Closed joshuahannan closed 1 year ago

joshuahannan commented 1 year ago

The public links need to use all the types in NonFungibleToken and TopShot for these purposes so they are compatible with as many 3rd party apps as possible. The Top Shot team should make sure they're following this transaction's model for linking an account

jrkhan commented 1 year ago

Out of curiosity, It would seem this transaction also be used to relink account collections at all expected paths? Would think this might address this issue? (Per @bjartek) https://github.com/dapperlabs/nba-smart-contracts/issues/204

bjartek commented 1 year ago

Not the way it is written right now no, but it is not hard to adapt it.