dapperlabs / nba-smart-contracts

Smart contracts and transactions for Topshot, the official NBA digital collectibles game on the Flow Blockchain
https://www.nbatopshot.com
The Unlicense
336 stars 104 forks source link

emit withdraw event when burning #247

Closed austinkline closed 7 months ago

austinkline commented 7 months ago

There is no standard destruction event that all NFT Collections follow. Because of that, indexers that pull in all NFT events on flow can miss destruction events if there is no corresponding withdraw to go along with it.

This change will emit a withdraw event to signal to indexers that ownership of an item has changed along with it being burned. This will ensure that indexers at least see that ownership is empty at the end of a transaction without needing to know that anything about TopShot itself