dapperlabs / nfl-smart-contracts

11 stars 2 forks source link

Implement MetadataViews And Core Views. #14

Closed prpatel05 closed 2 years ago

prpatel05 commented 2 years ago

resolves #11

This PR implements MetadataViews and all the Core Views for the AllDay NFT. This change will allow AllDay to be onboarded to the NFT Catalog. Therefore allowing NFT interoperability and discoverability on-chain.

Any of the Views can be changed to incorporate the correct/preferred information.

This change closely mirrors the implementation of MetadataViews from the TopShot contract -

TODO Before we can deploy this contract, there needs to be a way to fetch assets based on the NFT ID (and not the off-chain UUID). The proposal in this PR is to match what TopShot is doing (CloudFlare worker to translate the on-chain ID -> off-chain ID when pulling the asset). As part of this PR, we will finalize if this is the preferred option. If not, we can update this PR to implement the agreed upon method.

austinkline commented 2 years ago

@prpatel05 any update on this PR? With All Day now non-custodial, it would be nice for it to implement the NFT metadata standards linked here but seems like some TODOs are still remaining?

prpatel05 commented 2 years ago

Closing in favor of https://github.com/dapperlabs/nfl-smart-contracts/pull/16