search

dapperlabs / nfl-smart-contracts

11 stars 2 forks source link

Update NFL contracts & txs to Cadence 1.0 #25

Closed bshahid331 closed 2 months ago

joshuahannan commented 7 months ago

@bshahid331 it is likely that most of my comments from the Top Shot review will apply to your changes here too, so I would recommend doing the same things I suggested there to the contracts here too. Then let me know when you finish and I can review

Deewai commented 2 months ago

@bshahid331 it is likely that most of my comments from the Top Shot review will apply to your changes here too, so I would recommend doing the same things I suggested there to the contracts here too. Then let me know when you finish and I can review

@joshuahannan can you take another look. Addressed the comments from the nba PR