search

dappforce / subsocial-solochain

NOTE: Development continues in https://github.com/dappforce/subsocial-parachain repo. Subsocial full node with Substrate/Polkadot pallets for decentralized communities: blogs, posts, comments, likes, reputation.
http://subsocial.network
GNU General Public License v3.0
81 stars 23 forks source link

Upgrade `pallet-faucets` to FRAME v2 #214

Closed Doordashcon closed 2 years ago

Doordashcon commented 2 years ago

TODO

Doordashcon commented 2 years ago

tbh i think this pallet needs a change, for one the ability to create a new faucet should be possible through a helper function cc @siman

F3Joule commented 2 years ago

tbh i think this pallet needs a change, for one the ability to create a new faucet should be possible through a helper function cc @siman

I see it like: we have a common function, but 2 different dispatch calls: force_add_faucet, add_faucet. The last one can create a faucet from caller account. The force one can create a faucet from any account, but caller should be root.

Doordashcon commented 2 years ago

@F3Joule currently add_faucet dispatch can only be called by root and accepts an accountId, force_add_faucet does not exist.

F3Joule commented 2 years ago

@F3Joule currently add_faucet dispatch can only be called by root and accepts an accountId, force_add_faucet does not exist.

I mean, imo, we should do like I've described.

Doordashcon commented 2 years ago

@F3Joule Do we have a specific spec machine for producing weights?

Doordashcon commented 2 years ago

Hi @F3Joule Are the changes acceptable? I want to work on other pallets