dapphp / radius

A pure PHP RADIUS client based on SysCo/al implementation
GNU Lesser General Public License v3.0
80 stars 43 forks source link

dapphp/radius v2.5.5 can be installed in PHP 8 #20

Closed jawira closed 3 years ago

jawira commented 3 years ago

Hi, dapphp/radius v2.5.5 is not compatible with PHP 8, but it's possible to install the library in any PHP version.

The problem is php's version constraint in composer.json, the following code makes the library installable in ALL php versions:

{
 "require": {
        "php": ">=5.3 || <= 7.4"
    },
}

Please check: https://jubianchi.github.io/semver-check/#/%3E%3D5.3%20||%20%3C%3D%207.4/8.0.0

Instead you should write:

{
 "require": {
        "php": "^5.3 || ^7.0"
    },
}

Hope you can fix it, thanks.

Edit: I fixed a mistake in my code, it should be ^5.3 || ^7.0, not ^5.3 || ^7.3 :P

jawira commented 3 years ago

Closing issue since my new employer doesn't use Radius :)