dapphub / dapple

EVM contract system developer multitool
GNU General Public License v3.0
299 stars 59 forks source link

refactor dapple install #190

Open mhhf opened 8 years ago

mhhf commented 8 years ago

refactor install and dependencies: work with pure functions and clear cli type install args. dapphub as default

dapple install dappsys # install from dapphub
dapple install ipfs://asdasdas --ipfs
dapple install git://adasdasd --git
mhhf commented 8 years ago

When I think about this, we should probably deprecate it all together and make installing from dapphub the only option when installing from cli. @ryepdx @nmushegian Thoughts?

nmushegian commented 8 years ago

I'd like to support referring to packages by ipfs hash.

ghost commented 8 years ago

I feel like I can see both sides to this one, since removing the extra sources could simplify the codebase and since one could argue including additional installation sources might be an example of YAGNI. On the other hand, that sort of functionality is available in package managers such as NPM and Pip, so developers are probably going to approach Dapple with the expectation that it too will support installing from git repositories, HTTP servers, IPFS, etc. I'm inclined to follow the herd on this one because of that, but I'd also be interested in hearing counterarguments.

dbrock commented 8 years ago

Isn't "Install from IPFS hash" simply one of two steps in "Install from Dapphub" (the first step being "Download IPFS hash from Dapphub")?

ghost commented 8 years ago

Yeah, it is. Enabling installation from IPFS hash would basically just be a matter of changing the place from where the hash is pulled.