search

dapphub / dapple

EVM contract system developer multitool
GNU General Public License v3.0
299 stars 59 forks source link

[proposal] Use "Javascript Standard" style #86

Closed ghost closed 8 years ago

ghost commented 8 years ago

Right now Dapple's code style is a bit inconsistent. I'd like to propose adopting a style guide of some sort. I've seen the Javascript Standard style floating around, and it looks as good as any other to me. Plus it has the advantage of having tools available that would allow us to incorporate style checking into our workflow.

Looking for feedback from @nmushegian @mhhf @drupalnomad and anyone else who might consider themselves a stakeholder in this decision.

mhhf commented 8 years ago

I like the Idea of a style guide and the one you've picked sounds reasonable to me. We can at least try this out and see if the adoption comes natural. :+1:

However, I'm a little bit sceptical about the "no semicolons" thing. (airbnb and google don't agree either)

c055 commented 8 years ago

i like it as well!

However, I'm a little bit sceptical about the "no semicolons" thing. (airbnb and google don't agree either)

yep ..i would intend to agree @mhhf here

ghost commented 8 years ago

Alright, so it sounds like Semistandard is what we'll go with, unless there are objections from anyone else. I'll leave this issue open for another day to give time for dissenting opinions to be voiced before adding the badge to our README and incorporating the style checker into my workflow.

c055 commented 8 years ago

+1

nmushegian commented 8 years ago

I'll add this to travis if I get help with https://github.com/NexusDevelopment/dapple/issues/109