Open asymmetric opened 5 years ago
I realized there's a problem with the VERSION
file:
VERSION
file to the store. We could, but I think a better approach is to insert its contents inside dapp---version
.Makefile
directly, this would break.Which begs the question of if we still want to support installation with make
.
Agree that a single source of truth would make versioning more manageable. Could we somehow use the latest git tag?
I mean we could come up with a script that takes in the program (e.g. "dapp") and the new version as inputs and bumps them everywhere. Could work. Might be a bit messy/brittle though.
Also I think the tag should be added when the branch is merged on master, not on the side branch, so we'd still have to take care of that separately.
Some notes I took when upgrading the solc
version, maybe relevant for any future automation work:
dapphub/nixpkgs:master
to nixos/nixpkgs:master
solc-X.Y.Z
) from dapphub/nixpkgs:master
pkgs/development/compilers/solc/default.nix
version
to X.Y.Z
rev
and sha256
based on the output from nix-prefetch-git git@github.com:ethereum/solidity.git vX.Y.Z
nix-build -A solc
from the repo rootnix-env -f . -iA solc
) and run a few
tests to make sure everything is OK.solc-X.Y.Z
) in dapphub/dapptools
nix/solc-versions.nix
solc_X.Y.Z
in the unreleased
sectionrev
and sha256
based on the output from nix-prefetch-git git@github.com:dapphub/nixpkgs refs/heads/solc-X.Y.Z
dapp---version
, default.nix
and the changelogdapphub/dapptools:solc-X.Y.Z
to dapphub/dapptools:master
dapphub/nixpkgs:solc-X.Y.Z
to nixos/nixpkgs:master
dapphub/dapptools
moving the solc_X.Y.Z
from the unreleased
to the darwin
section in solc-versions.nix
A couple of ideas for GitHub bots:
Currently, releasing a new version of e.g. dapp requires:
dapp --version
CHANGELOG
This is error-prone and has already resulted in a few mistakes.
One way to walk towards a more manageable solution is to institute a
VERSION
file for each tool, read by both the nix package and the--version
subcommand. This would allow us to eliminate the first two steps above.A next step could be to create a script that bumps the version in
VERSION
and performs operations/sanity checks:dapp/x.y.z
/cc @nanexcool @desaperados