dapphub / dapptools

Dapp, Seth, Hevm, and more
https://dapp.tools
2.1k stars 325 forks source link

hevm/dapp tries to link libraries that have all internal functions #727

Open transmissions11 opened 3 years ago

transmissions11 commented 3 years ago

This is unnecessary and increases the build time dramatically. I manually disable library linking with the env var but it always gets overriden for debugging (even tho it is unnecessary)

d-xo commented 3 years ago

relevant:

https://github.com/dapphub/dapptools/blob/2b2c2a010f1a22a664cf17861c0d6812077f02b7/src/dapp/libexec/dapp/dapp---find-libraries#L4-L14

transmissions11 commented 3 years ago

made a PR to address a symptom of this (if merged dapp debug would respect DAPP_TEST_LINK_LIBRARIES): https://github.com/dapphub/dapptools/pull/728