.DS_Store file in ./lib gets falsly identified as git submodule

dapphub / dapptools

Dapp, Seth, Hevm, and more

https://dapp.tools

2.1k stars 325 forks source link

.DS_Store file in ./lib gets falsly identified as git submodule #887

Open TimDaub opened 2 years ago

TimDaub commented 2 years ago

Because I was using the Mac OS browser, I ended up having a .DS_Store at ./lib/.DS_Store of a dapptools project. Technically there shouldn't be any .DS_Store files in ./lib. But also dapp test and dapp update should just ignore it

dapp test
dapp-remappings: error: ./lib/.DS_Store is not a Git repository

transmissions11 commented 2 years ago

this should be fixed on master https://github.com/dapphub/dapptools/pull/778