search

dapphub / dpack

simple lockfile for your dapp's addresses and artifacts
46 stars 9 forks source link

'create weth pack' - check that entry does not already exist #44

Closed kbrav closed 2 years ago

kbrav commented 2 years ago

The test shouldn't add data that already exists. I'm trying to figure out how to cleanup the entry so that ipfs cat fails -- it seems it works even in offline mode after pin rm and repo gc.

kbrav commented 2 years ago

5475cba makes the test fail, 78aa122 fixes it as long as ipfs daemon is running with --offline. Without --offline we'd be getting the data from each other rather than creating and uploading it.

nmushegian commented 2 years ago

Not sure the value of checking that the data doesn't exist, because as you observe, someone else might have happened to put the same exact file in ipfs We just want to know that what we add is right