search

dapphub / dpack

simple lockfile for your dapp's addresses and artifacts
46 stars 9 forks source link

feat: add `jams` support #55

Closed lonerapier closed 2 years ago

lonerapier commented 2 years ago

Motivation

Hopes to Resolve #54 ;)

nmushegian commented 2 years ago

Good now let’s add a test, I know we didn’t have one but that’s no excuse haha

lonerapier commented 2 years ago

Good now let’s add a test, I know we didn’t have one but that’s no excuse haha

Yup, that's what I was gonna ask. But current tests aren't working with this change.

Still getting module not found errors, when running tests.

dmfxyz commented 2 years ago

@dsam82 I cloned your fork and was able to get tests passing locally without any changes. are you still running onto this issue?

lonerapier commented 2 years ago

@dsam82 I cloned your fork and was able to get tests passing locally without any changes. are you still running onto this issue?

Unfortunately, yes. Have still added the tests, but can't remove this stupid error on my system.

stobiewan commented 2 years ago

@dmfxyz Were you on the feat/jams-support branch when you had tests passing? I get the same failures

dmfxyz commented 2 years ago

@dsam82 I cloned your fork and was able to get tests passing locally without any changes. are you still running onto this issue?

Ignore this -- I was on the wrong branch.