search

dapphub / ds-note

Log function calls as events
https://dapp.tools/dappsys/ds-note.html
GNU General Public License v3.0
17 stars 23 forks source link

Compilation fails with solc 0.5.8 #4

Open elenadimitrova opened 5 years ago

elenadimitrova commented 5 years ago

Error:

/lib/dappsys/stop.sol:33:34: TypeError: This modifier uses "msg.value" or "callvalue()" and thus the function has to be payable or internal.
    function start() public auth note {
                                 ^--^
/lib/dappsys/note.sol:36:20: "msg.value" or "callvalue()" appear here inside the modifier.
            wad := callvalue
                   ^-------^
gbalabasquer commented 5 years ago

Yes it is a known issue with compilers > 0.5.6. We are probably removing the callvalue soon.