search

dapphub / ds-proxy

a proxy object that can compose transactions on owner's behalf
https://dapp.tools/dappsys/ds-proxy.html
GNU General Public License v3.0
312 stars 77 forks source link

dynamic return values #12

Closed nmushegian closed 5 years ago

nmushegian commented 7 years ago

byzantium fork allows dynamically sized return values

rainbreak commented 7 years ago

@gbalabasquer be aware of this

nmushegian commented 6 years ago

@NiklasKunkel too

Jake-Gillberg commented 6 years ago

Would the proxy be able to compute the return size of the function it is delegatecalling?

rainbreak commented 6 years ago

@Jake-Gillberg yes, RETURNDATASIZE and RETURNDATACOPY can be used to access the full return data. We should probably update ds-proxy now to return bytes rather than bytes32 (or as well as, if backwards compat is important).

NiklasKunkel commented 6 years ago

If this isn't high priority I'd like to take this one once I finish up with Oracles for MCD.

On Sat, Oct 13, 2018 at 2:55 AM rain notifications@github.com wrote:

@Jake-Gillberg https://github.com/Jake-Gillberg yes, RETURNDATASIZE and RETURNDATACOPY can be used to access the full return data. We should probably update ds-proxy now to return bytes rather than bytes32 (or as well as, if backwards compat is important).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dapphub/ds-proxy/issues/12#issuecomment-429527281, or mute the thread https://github.com/notifications/unsubscribe-auth/ABu7vReSMeBmXUq4rcBRdUrfhIJ4Wsrcks5ukbiUgaJpZM4P6AWF .

gbalabasquer commented 6 years ago

We should probably upgrade this before releasing the new CDP Dashboard as we avoid post migration. I'll take a look and check with you @NiklasKunkel

gbalabasquer commented 5 years ago

This was done.