search

dapphub / ds-proxy

a proxy object that can compose transactions on owner's behalf
https://dapp.tools/dappsys/ds-proxy.html
GNU General Public License v3.0
312 stars 77 forks source link

add 'reserve' variable instead of hard coded gas of 5000 for delegatecall #13

Open r001 opened 7 years ago

r001 commented 7 years ago

Minor update to add variable instead of hard coded gas value in delegatecall.

rainbreak commented 5 years ago

To clarify: this is to future proof ds-proxy against gas pricing changes in the EVM.

@gbalabasquer @NiklasKunkel want to restate any opinions here?

gbalabasquer commented 5 years ago

I'd merge this. I hope the gas prices do not change enough to over pass the 5000, otherwise we will be in a trouble. Then I say in a nice thing to have. My only question would be if there is any added value to declare the variable as uint128 instead of uint256.

NiklasKunkel commented 5 years ago

The 5000 gas is so far over the current actual cost that it should be immune to future restructuring of gas prices.

On Sat, Nov 24, 2018 at 8:13 AM Gonzalo Balabasquer < notifications@github.com> wrote:

I'd merge this. I hope the gas prices do not change enough to over pass the 5000, otherwise we will be in a trouble. Then I say in a nice thing to have. My only question would be if there is any added value to declare the variable as uint128 instead of uint256.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dapphub/ds-proxy/pull/13#issuecomment-441378252, or mute the thread https://github.com/notifications/unsubscribe-auth/ABu7vdx48GqXQpvg0FgZ2MtSzSUddbE6ks5uyXAdgaJpZM4Qh-8j .

gbalabasquer commented 5 years ago

Yeah I guess the 4200 gas gap should be more than enough, however should it hurt somehow to have it manageable?