search

dapphub / ds-token

A simple and sufficient ERC20 implementation
https://dapp.tools/dappsys/ds-token.html
GNU General Public License v3.0
226 stars 76 forks source link

Compatibility for solc 0.5/0.6 #29

Closed gbalabasquer closed 4 years ago

gbalabasquer commented 4 years ago

This PR proposes to remove DSTokenBase and ERC20 contracts to be able to compile DSToken with solc 0.5 and 0.6.

It doesn't touch anything regarding symbol and name which are bytes32 in opposition to the standard string. That can be discussed separately.

gbalabasquer commented 4 years ago

FV specs fully being accepted with solc 0.5.12 - non optimized: https://github.com/makerdao/k-ds-token

(In order to simplify FV, DSStop has been removed as a submodule and the same functionality incorporated directly in the token code with a simpler event emission).

gbalabasquer commented 4 years ago

FV with 0.6.7 - non optimized is also fully being accepted.

gbalabasquer commented 4 years ago

FV with 0.6.7 being fully accepted with optimization and 999999 runs: https://github.com/makerdao/k-ds-token/tree/7f6678bf18049585371da2fa44085fa7c7ffc967

Report: https://reports.makerfoundation.com/k-ds-token/4384d9f2681d84b3819c/

cc @xwvvvvwx