search

dapphub / klab

K framework proof explorer & smart contract specification format
GNU Affero General Public License v3.0
123 stars 36 forks source link

Strip metadata before calculating proof hash #406

Open asymmetric opened 4 years ago

asymmetric commented 4 years ago

So that changes that don't affect the bytecode don't cause a cache miss.

livnev commented 4 years ago

https://github.com/dapphub/dapptools/commit/78508c6a8db2d6d3e8e09437dbe122bb5e6b2e7e Using the methodology introduced in this commit (or potentially the methodology from before) could be one way.

d-xo commented 4 years ago

Could we expose this as a command in hevm / seth? (smth like hevm --strip-metadata) and then just reuse it in klab?

MrChico commented 4 years ago

https://github.com/dapphub/dapptools/pull/357 a little more verbose than one would like perhaps (hevm strip-metadata --code XXXXXX), but an easy way to get the job done while keeping in line with the constraints of optparse generic

asymmetric commented 4 years ago

Closed by dapphub/dapptools#357.

d-xo commented 4 years ago

@asymmetric I don't think the linked PR closes this issue? We still need to incorporate this functionality in klab afaik?

asymmetric commented 4 years ago

Ah, I thought we would do it manually, sorry. Feel free to reopen if that’s not the case.

asymmetric commented 4 years ago

It makes more sense to include it as part of the build process, I agree 👍