search

dappnode / DAppNode

General repository of the project dappnode
GNU General Public License v3.0
588 stars 104 forks source link

Add Wireguard to all install conditions #486

Closed alexpeterson91 closed 2 years ago

alexpeterson91 commented 2 years ago

adding wireguard to all install configs. will fix the update script from gutting wireguard when it's run. I dont see any situation where wireguard shouldnt be installed, unlike HTTPS etc.

@pablomendezroyo please let me know if you see any issue with this change, I'd like to merge this asap if theres no reason not to.

pablomendezroyo commented 2 years ago

I would install just one VPN solution, openvpn or WireGuard. Instead of both of them.

@3alpha @tropicar thoughts?

alexpeterson91 commented 2 years ago

@pablomendezroyo we should just do wireguard its so much more stable and already ready for docker network migration. we need to change other things like the docs and the commands in the main console about open VPN

3alpha commented 2 years ago

We had to leave OpenVPN as option because there were some issues with Linux kernel and Wireguard in VPSes with older Linux releases installed. But now, when Wireguard became standard, I am for depreciating DNP_VPN and using just Wireguard.

pablomendezroyo commented 2 years ago

We must install Wireguard as the first option and OpenVPN as a fallback, in case there is no possibility to install Wireguard. For example, if the following prerequisite installation fails https://github.com/dappnode/DAppNode/blob/ee1e0c90ff318977c80deecb80196c3d1a63fa5b/scripts/dappnode_install_pre.sh#L120

Regarding commands and docs, we must keep them in favor of backward compatibility but encouraging users to switch to Wireguard

alexpeterson91 commented 2 years ago

DAppNode/scripts/dappnode_install_pre.sh

Ok I see, I can make an issue for that, but for just this one commit adding wireguard to all conditions as i have here, will fix the update script from gutting wireguard if it's already been installed which it is for most users. This wont remove openVPN, or anything, can this be merged if i open an issue documenting the transition of Open_VPN to wireguard and that we need to implement a check to see if OpenVPN needs to be installed as well?