dappnode / DAppNode

General repository of the project dappnode
GNU General Public License v3.0
581 stars 99 forks source link

Create `dncore_network` with private IP range (Installer) #547

Open pablomendezroyo opened 1 year ago

pablomendezroyo commented 1 year ago

Create the docker dncore_network with a private IP range.

See https://github.com/dappnode/DAppNode/blob/8698abc44ea3cd2b53322433f760d1bf08f78eb1/scripts/dappnode_install.sh#L321

pablomendezroyo commented 1 year ago

Should be done the last

javyer commented 12 months ago

172.33.0.0/16 is not a local private network... Is there any reason why 172.33 was used ? Private ranges is only : 172.16.0.0 to 172.31.255.255

pablomendezroyo commented 12 months ago

@javyer Yes we know, that's why we are planning to migrate the IP range. It has been done like this since the beginning and now it would be harder to migrate. But we will!