dappnode / DAppNode

General repository of the project dappnode
GNU General Public License v3.0
581 stars 99 forks source link

Bump gha checkout from v2 to v3 #570

Closed pablomendezroyo closed 9 months ago

pablomendezroyo commented 1 year ago

Issue GitHub actions checkout V2 script seems to be deprecated and this is making all the actions fail (see examples of failures), see an example of the checkout implementation.

Solution Bump the GitHub actions checkout from V2 to V3 (i.e erigon PR) and open a PR

ziogaschr commented 1 year ago

Is the https://github.com/dappnode/DAppNodePackage-goerli-erigon/pull/4 related? Probably it's a wrong copy/paste. :)

I bumped the checkout version here but the issue is not solved.

pablomendezroyo commented 1 year ago

Thanks for the typo report!

Checking your case

pablomendezroyo commented 1 year ago

@ziogaschr the issue seems to be the checkout actions v3 setting the default node version 16 which is incompatible with the minimum engine version 18 the sdk requires

Checkout this PR https://github.com/dappnode/DAppNodePackage-goerli-erigon/pull/42

ziogaschr commented 1 year ago

Thanks for the help @pablomendezroyo. The issue persists in the release action at erigon here

alexpeterson91 commented 1 year ago

@pablomendezroyo let me know if you want me to go around and do this on all our repos, ive done it to a bunch of the repos i work with regularly, and implemented it on all my GHAs of my forks in my organization solved a lot of problems for me, not everything but it's made a bunch of packages start working again with CI etc. i just run into issues with releases/bump upstream on unpublished packages, like erigon gnosis, which is working pretty damn good so far ive got it working beautifully with no external CL just using the internal CL.
So let me know if i should just be going around and do the tedious task of updating every repo we have. or at least adding PRs for it on all packages. I also just checked some open issues with Github Checkout, github actions and github runners, and added a comment or 2 on several issues of people asking for node18 support, node16 is supposed to be EoL like September this year, some talked about going straight to Node20, but others asked for node 18 too, so i did too. apparently theres a bunch of people looking for an answer to when and if Node18 is gonna be implemented on the runners, im subscribed to some of the threads now too so hopefully something gets resolved shortly

pablomendezroyo commented 1 year ago

Hey, yeah souds great, you could implement a script to do that:

git clone repo
cd repo
if .github/workflows/*.yml | grep github actions checkout v2
then
....change it to v3
fi
cd ..

Just as a quick example

alexpeterson91 commented 1 year ago

Will do, ive already have been doing backups of all dappnode repos every once in a while, so ill refresh mine and try my scripting skills.

stale[bot] commented 12 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] commented 9 months ago

This issue or pull request has been automatically been closed due to inactivity.