dappnode / DAppNodePackage-bitcoin

DAppNode package for bitcoin full node daemon
GNU General Public License v3.0
4 stars 7 forks source link

Allow rpcallowip field to be configurable #28

Closed Leibniz137 closed 2 years ago

Leibniz137 commented 2 years ago

- 0.23 was recently released

dapplion commented 2 years ago

CC @tropicar

tropicar commented 2 years ago

As @alexpeterson91 said, if we want to implement this feature, you should create an issue explaining why we would have to add these options to the package. We need that information in order to decide if it is a good idea to do it in a package by default that everybody will use. Thank you for the feedback!

Leibniz137 commented 2 years ago

reverted the various version changes so it's just the single feature.

I will open an issue and reference it here. I think it's pretty reasonable change, to keep whatever you want for that value as the default, but just allow the user to change it if they want to in the config section of the package.

alexpeterson91 commented 2 years ago

Just gotta remember to change this when we change this too when we do the docker subnet