search

dappnode / DAppNodePackage-nethermind

Nethermind Ethereum client
Other
8 stars 7 forks source link

Allow sync mode to be snap sync. #95

Closed alexpeterson91 closed 1 year ago

alexpeterson91 commented 2 years ago

allow sync mode to be snap sync for 10x faster sync times

Must be tested due to possible issues with already synced clients Update: no isssues found with clearing DB or not after months of testing Reference: https://docs.nethermind.io/nethermind/ethereum-client/sync-modes#snap-sync

Changed to Allow Snap Sync Via Advanced mode/advanced editor, doesnt change default setting

Fixes #94

tropicar commented 2 years ago

I have tested this way of syncing in a synced nethermind node and I had no problem yet, but according to the Nethermind documentation. 

IMPORTANT: Do not enable snap sync on a previously synced node. Only use when syncing to the network for the first time.

So we have to be very careful with this option

alexpeterson91 commented 2 years ago

Yes I have a link to those docs and mentioned this in the linked issue. I guess I wanna see what happens if I upgrade to it being snap sync while synced will actually do. The CI is not publishing a IPFS hash to test. Build is taking like 20s only. Is there something up with the workflow on this repo?

alexpeterson91 commented 1 year ago

It’s been tested for months just not widely should be made default if there’s no db but not if not. probably more than we think since a bunch of users do custom Configs which I didn’t think was ever common and is a bad idea here for mainnet. Especially as repo client. 

@3alpha approved this pull request.

In principle this is fine, but testing is needed.

alexpeterson91 commented 1 year ago

In principle this is fine, but testing is needed.

Forgot to add selection to advanced setup wizard. Will need another review shortly.