search

dappnode / DAppNodePackage-vipnode

https://vipnode.org - Economic incentive for running Ethereum full nodes. The goal is to allow the Ethereum network to remain decentralized by creating a financial marketplace for more people to run full nodes and serve native light clients
GNU General Public License v3.0
1 stars 1 forks source link

dappnode should use the latest tagged version #2

Open shazow opened 5 years ago

shazow commented 5 years ago

~Getting some complaints from dappnode users like: https://github.com/vipnode/vipnode/issues/33~

I'm currently in the process of breaking some compatibility in master with the main pool.vipnode.org pool. Ideally, dappnode should be using the latest tagged release, ~but this person has an untagged master build running~.

Edit: Looks like the errors are unrelated to the Dockerfile config, which hardcodes the v2.0 tag.

Still, it would be nice to get some version consistency. Would it make sense to change the Dockerfile to use the latest tagged version?

Or, if Vipnode starts maintaining its own docker image for the latest release, would you want to switch to that?

shazow commented 5 years ago

Looks like the issue is unrelated to the error report, updated the issue.

shazow commented 5 years ago

FYI: Just released v2.1 which should be backwards-compatible with v2.0 and forwards-compatible with planned v3.0 API changes (which won't be backwards-compatible with v2.0). More notes here: https://github.com/vipnode/vipnode/releases

Also I'm maintaining a docker image here: https://cloud.docker.com/repository/docker/shazow/vipnode

If you'd like to use it, please use the :release tag, which should be the latest stable release (what the demo pool is running). The :latest tag is master, which I don't recommend using unless you're running your own pool. :)

vdo commented 5 years ago

Hi @shazow

Thanks for the heads up. About using your latest tagged image, we need to do some small tweaks to your Dockerfile to make it work with DAppNode, so we need to maintain our own version, but it will be based on yours. Also, we don't want to pull images from Dockerhub (we want to keep it distributed in IPFS)

shazow commented 5 years ago

That's fair.

What's the best way to make sure that DAppNode is running the correct version of Vipnode with releases in the future?

I want to do a major v3.0 release someday (probably several months away), so coordinating upgrading would make things easier.