dappnode / DNP_DAPPMANAGER

Dappnode package responsible for providing the Dappnode Package Manager
GNU General Public License v3.0
29 stars 40 forks source link

Add consensus client to `fullnode.dappnode` feature #1370

Open pablomendezroyo opened 1 year ago

pablomendezroyo commented 1 year ago

The fullnode.dappnode is an alias added to the selected execution client by the user. This way, other dappnode packages can use this alias to make requests to the execution client. Add to the existing feature fullnode.dappnode the consensus client selected.

alexpeterson91 commented 1 year ago

I like it. Good use of up-cycling of what was an essentially deprecated feature or at least one that sees very little use anymore. I am Curious what the endpoint would be if using the multicaster for your full node with idk geth priority 1 and besu at priority 2 selected with Teku as the driving consensus client. Would fullnode.execution.dappnode use the load balanced execution Multicaster execution engine endpoint http://execution-multicaster.dappnode or would it use the highest priority execution layer selected in the multicaster. In this example geth. ? Idk the current status of the multicaster either I suppose so this may not have even been a consideration yet. But will be relevant eventually.

pablomendezroyo commented 1 year ago

Would fullnode.execution.dappnode use the load balanced execution Multicaster execution engine endpoint http://execution-multicaster.dappnode

@alexpeterson91 yeah! thats a good point to add to the issue

pablomendezroyo commented 6 months ago

@dappnodedev whats the status?