search

dappnode / DNP_DAPPMANAGER

Dappnode package responsible for providing the Dappnode Package Manager
GNU General Public License v3.0
31 stars 40 forks source link

HTTPS Portal link broken in all packages network tab #1701

Open alexpeterson91 opened 11 months ago

alexpeterson91 commented 11 months ago

It seems this line below was updated in a way that is far too complex, and instead of just going to a single static page at http://my.dappnode/system/network it just makes the link loop back to the exact same page for any package

https://github.com/dappnode/DNP_DAPPMANAGER/blob/8714cff0835c51d7cfe0415fec2bcedf50b173ac/packages/admin-ui/src/pages/packages/components/Network/HttpsMappings.tsx#L150

This illustration show how the link to the HTTPS portal just links back to the page it's already on.

Screenshot 2023-11-22 at 8 23 47 PM
alexpeterson91 commented 11 months ago

@pablomendezroyo I would submit a fix but am not sure why it was done this way i reviewed the commit and it seemed irrelevant to the rest of the changes but I wanted to see if there was something else this affects and why it was set like this in the first place before just trying to fix something i dont actually know what is doing, though i think it was just overlooked as this behavior is expected with the code as written but doesnt make any sense for UX. So let me know if im missing something or if i should just submit a fix to a static link or is this design meant to direct you to the correct prefix you're accessing (i.e. my.dappnode or dappnode.local) and then the second half of this line is written incorrectly so that it always brings you to the network page for the package, instead of the system network page with the HTTPS portal?