Do not block `packageInstall` if `exposeDefaultPorts` and/or `connectToPublicNetwork` fails - Githubissues

dappnode / DNP_DAPPMANAGER

Dappnode package responsible for providing the Dappnode Package Manager

GNU General Public License v3.0

30 stars 40 forks source link

Do not block `packageInstall` if `exposeDefaultPorts` and/or `connectToPublicNetwork` fails #1995

Open pablomendezroyo opened 2 months ago

pablomendezroyo commented 2 months ago

Review the logic behind

connectToPublicNetwork : see https://github.com/dappnode/DNP_DAPPMANAGER/blob/680afa44b65c9c5db34df65bd0c53d55d040c567/packages/installer/src/installer/runPackages.ts#L102
exposeByDefaultHttpsPorts: see https://github.com/dappnode/DNP_DAPPMANAGER/blob/680afa44b65c9c5db34df65bd0c53d55d040c567/packages/installer/src/installer/runPackages.ts#L103

And bypass on error