dappnode / mev-sp-oracle

3 stars 1 forks source link

Exiting validators without unsubscribing does not remove them from the pool #227

Closed MrYukonC1 closed 1 month ago

MrYukonC1 commented 2 months ago

Describe the bug

Exiting validators without first unsubscribing, results in the pool incorrectly thinking the validators are still subscribed -- the subscriber count does no go down to reflect the number of exited validators.

Additionally, this directly (negatively) affects the calculated awards for all remaining subscribed validators -- they are getting less because the pool is still accumulating awards to validators that are no longer subscribed or validating.

To Reproduce

  1. subscribe to Smooth
  2. exit validator without unsubscribing