search

dappsnation / akita-ng-fire

Akita ❤️ Angular 🔥 Firebase
MIT License
131 stars 27 forks source link

Bugfix: Add entity id to store update #134

Closed TimVanMourik closed 4 years ago

TimVanMourik commented 4 years ago

Type Solves issue #135

Description This passes the updated entity to the store, such that the entity instead of the store itself is updated.

Notes I tested this by manually running an runEntityStoreAction(storeName, EntityStoreAction.UpdateEntities, update => update(entityIds, data)) in my application, not via this library. So I am not sure if this fix covers all cases of akita-ng-fire. Notable, entityIds is a string | string[] and I am not sure if this works for string[]

fritzschoff commented 4 years ago

thanks for the PR. I will check how it behaves if it is an array!