search

dappsnation / akita-ng-fire

Akita ❤️ Angular 🔥 Firebase
MIT License
131 stars 27 forks source link

Update angular version to 11 and akita 6 #188

Closed alexis-mrc closed 3 years ago

alexis-mrc commented 3 years ago

Hi

I got WARN when building my angular app :

npm WARN akita-ng-fire@4.0.1 requires a peer of @angular/common@>=6.0.0 <11 but none is installed. You must install peer dependencies yourself.
npm WARN akita-ng-fire@4.0.1 requires a peer of @angular/core@>=6.0.0 <11 but none is installed. You must install peer dependencies yourself.
npm WARN akita-ng-fire@4.0.1 requires a peer of @angular/router@>=6.0.0 <11 but none is installed. You must install peer dependencies yourself.

I am using akita-ng-fire "akita-ng-fire": "^4.0.1" with angular 11 and everything seems working great but i am not using everything of the library. Is enough to update angular version in the package.json ?

I just saw tha akita released a new version (6.0.1) to remove dependency on tslib < 2

npm WARN @datorama/akita@5.3.0 requires a peer of tslib@>= 1.7.0 < 2 but none is installed. You must install peer dependencies yourself.
npm WARN @datorama/akita-ng-router-store@5.1.9 requires a peer of tslib@^1.9.0 but none is installed. You must install peer dependencies yourself.

I think it would be great to update dependency with akita too.

fritzschoff commented 3 years ago

Hey, thanks for letting us know. We will update this lib then to v5. About the warning that requires the angular libs. What do you mean you are not using anything from the lib?

alexis-mrc commented 3 years ago

For the warning, i am using angular >= 11

fritzschoff commented 3 years ago

Hey I published version 5 now. Let me know if that fixes it for you. You need akita version 6 now.