search

dappsnation / akita-ng-fire

Akita ❤️ Angular 🔥 Firebase
MIT License
131 stars 27 forks source link

Incorrect OAuth provider when using Apple sign-in #216

Closed pallehpetersen closed 2 years ago

pallehpetersen commented 2 years ago

Hey, I noticed a small bug when attempting to use Apple sign-in using the FireAuthService.

When using the FireAuthService to sign in using OAuth, the Apple AuthProvider is created using "apple" and not "apple.com", so it does not work.

https://github.com/dappsnation/akita-ng-fire/blob/3d019b539147cc1185016dd4d0d8e997273fd8a7/projects/akita-ng-fire/src/lib/auth/auth.service.ts#L53 The line here should be changed to

case 'apple': return new firebase.auth.OAuthProvider('apple.com');

Firebase documentation

GrandSchtroumpf commented 2 years ago

@pallehpetersen it has been fixed with version 6.0.5. Thanks for reporting.