search

dappsnation / akita-ng-fire

Akita ❤️ Angular 🔥 Firebase
MIT License
131 stars 27 forks source link

Update AngularFire v7 & Firebase v9 #217

Closed randallmeeker closed 2 years ago

randallmeeker commented 2 years ago

resolves #205

randallmeeker commented 2 years ago

Is there a prettier setup that should be used? I'm attempting to add rules that will limit all the white space changes to correspond with the formatting I see already present in the repo.

randallmeeker commented 2 years ago

@GrandSchtroumpf sorry mean to tag earlier.

GrandSchtroumpf commented 2 years ago

There is no prettier setup because I never managed to achieve something versatile enough for HTML, CSS & TS with prettier. I consider it ~impossible~ very difficult to enforce code understandability with the line width as main parameter. For example this update or this one look less understandable for me than the previous ones. I've no issue with adding prettier setup, but I would recommend to not mix PR purpose 🙂.

randallmeeker commented 2 years ago

I get that, I was gonna suggest a pre-PR where I just run whatever the Prettier defaults are already in the repo across the entire thing, then this merge into this.

randallmeeker commented 2 years ago

@GrandSchtroumpf

This builds and runs. However, the test suite does not seem to run, but this was the case before I started. Let me know if there are any suggestions there.

I did this off the 6.0.4 brach and as there were changes since v6 that needed updates.

Aside from getting the test suite up and running, I was going to try to upgrade one of my current projects with it, but it appears good to go.

GrandSchtroumpf commented 2 years ago

@randallmeeker I've updated the lib to fix this issue #216. I think you'll need to rebase your branch on v6 to have the latest version. Also I think this is a major update, therefore we should bump the version to 7.0.0. What we can do for the testing the lib would be to publish this with a next tag. To achieve that, you can

GrandSchtroumpf commented 2 years ago

outch I think something went wrong with the rebase here. The commits are in double and you've got conflicts. I would recommend a new branch fresh from v7 and cherry pick your commits. I think it would be faster than trying to clean the history / conflicts.