search

dappsnation / akita-ng-fire

Akita ❤️ Angular 🔥 Firebase
MIT License
131 stars 27 forks source link

Update AngularFire v7 & Firebase v9 #221

Closed randallmeeker closed 2 years ago

randallmeeker commented 2 years ago

I closed #217 and opened this one for simplicity/clarity sake.

resolves #205

@GrandSchtroumpf

hakimio commented 2 years ago

@randallmeeker that's a very lazy approach to the upgrade. Using "compat" imports will not give us proper tree-shaking support - the most notable feature of Firebase v9.

GrandSchtroumpf commented 2 years ago

@hakimio Please avoid agressive language. @randallmeeker did spend time working on this update, there is nothing lazy about her/his work. Contributing to an open source project is not an easy task and should be supported instead of discouraged. Other PRs to update the code to a newer version are welcome.

hakimio commented 2 years ago

@GrandSchtroumpf Ok, if no one else is taking this task, I'll look into doing proper upgrade sometime next week.

GrandSchtroumpf commented 2 years ago

@hakimio ok thanks. Can you write a comment on the issue to let the community knows about that : https://github.com/dappsnation/akita-ng-fire/issues/205