search

dapr / cli

Command-line tools for Dapr.
Apache License 2.0
315 stars 200 forks source link

Installs,uninstalls,upgrade dapr-dashboard separately when applicable. #1272

Closed artursouza closed 1 year ago

artursouza commented 1 year ago

Description

Handles Dapr Dashboard's Helm chart separately.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Related to https://github.com/dapr/dapr/issues/4724

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

pravinpushkar commented 1 year ago

Not sure why upgrade tests are failing to install dapr-dashbboard. As per changes in this PR, if chart has dashboard then it should install that and we are checking the clusterrole for dashboard existence. So, tests also should have worked.

artursouza commented 1 year ago

Not sure why upgrade tests are failing to install dapr-dashbboard. As per changes in this PR, if chart has dashboard then it should install that and we are checking the clusterrole for dashboard existence. So, tests also should have worked.

I will check. Thanks.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1272 (2d81413) into master (9f67738) will decrease coverage by 0.28%. The diff coverage is 4.34%.

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   27.37%   27.10%   -0.28%     
==========================================
  Files          38       38              
  Lines        3755     3800      +45     
==========================================
+ Hits         1028     1030       +2     
- Misses       2656     2699      +43     
  Partials       71       71
Impacted Files Coverage Δ
pkg/kubernetes/kubernetes.go 0.00% <0.00%> (ø)
pkg/kubernetes/renew_certificate.go 0.00% <0.00%> (ø)
pkg/kubernetes/uninstall.go 0.00% <0.00%> (ø)
pkg/kubernetes/upgrade.go 19.69% <0.00%> (-1.62%) :arrow_down:
pkg/version/version.go 71.05% <100.00%> (-0.19%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.